RussellSpitzer commented on a change in pull request #4379:
URL: https://github.com/apache/iceberg/pull/4379#discussion_r833459262
##########
File path: docs/spark/spark-procedures.md
##########
@@ -198,7 +198,7 @@ the `expire_snapshots` procedure will never remove files
which are still require
| Argument Name | Required? | Type | Description |
|---------------|-----------|------|-------------|
| `table` | ✔️ | string | Name of the table to update |
-| `older_than` | ️ | timestamp | Timestamp before which snapshots will be
removed (Default: 5 days ago) |
+| `older_than` | ️ | timestamp | Timestamp before which snapshots will be
removed (Default: 5 days ago). Considered upto millisecond precision. |
Review comment:
I'm just not sure how often folks would expect their microsecond values
to matter in snapshot expiration, I generally think about snapshots at best at
a ms granularity but I think for most real cases uses are going to be on the
second granularity or higher.
I just worry sometimes that we add information that is technically correct
but not useful for a user setting the value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
