szehon-ho commented on a change in pull request #4382:
URL: https://github.com/apache/iceberg/pull/4382#discussion_r834874605
##########
File path: core/src/main/java/org/apache/iceberg/BaseMetadataTableScan.java
##########
@@ -38,4 +44,14 @@ public long targetSplitSize() {
TableProperties.METADATA_SPLIT_SIZE_DEFAULT);
return PropertyUtil.propertyAsLong(options(), TableProperties.SPLIT_SIZE,
tableValue);
}
+
+ /**
+ * Alternative to {@link #planFiles()}, allows exploring old snapshots even
for empty table.
+ */
+ protected CloseableIterable<FileScanTask> planAllFiles() {
Review comment:
Yea this was tricky and I went back and forth with various solutions.
It is relevant for Files and other tables like AllManifests, AllEntries.
BaseAllMetadataTableScan used to override planFiles() , and was inherited by
AllDataFiles, AllManifests, AllEntries. Now moving AllDataFiles to
BaseFilesTableScan. Hence moving the method up to the common parent, so it can
be shared by the two hierarchies (BaseAllMetadataTableScans and
BaseFilesTableScan), though we don't get the free override anymore as
AllDataFiles cannot have multiple inheritance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
