RussellSpitzer commented on a change in pull request #4382:
URL: https://github.com/apache/iceberg/pull/4382#discussion_r839038358



##########
File path: core/src/main/java/org/apache/iceberg/BaseMetadataTableScan.java
##########
@@ -31,11 +37,30 @@ protected BaseMetadataTableScan(TableOperations ops, Table 
table, Schema schema,
     super(ops, table, schema, context);
   }
 
+  /**
+   * @return if metadata table scan is for all snapshots, ie 'all_x' metadata 
tables
+   */
+  protected boolean allScan() {

Review comment:
       How about allSnapshotsScan ? Also the doc for return only JavaDocs 
should be
   ```
   /**
   * Return .....
   **/
   ```
   This will populate the javadoc Summary field, otherwise it will be blank 
with the only documentation in the method detail.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to