wypoon commented on a change in pull request #4395:
URL: https://github.com/apache/iceberg/pull/4395#discussion_r835641827



##########
File path: 
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java
##########
@@ -193,15 +200,41 @@ public boolean supportColumnarReads(InputPartition 
partition) {
     }
   }
 
+  static long numFilesToScan(CombinedScanTask scanTask) {
+    long fileCount = 0L;
+    for (FileScanTask file : scanTask.files()) {
+      fileCount += 1L;

Review comment:
       We could have a separate metric for number of delete files to read. Or 
rather, a sum of the number of delete files to apply, over the data files to be 
read; we won't actually track what the delete files are, if there is any 
overlap among them (can there be overlap?).
   @rdblue @aokolnychyi what do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to