RussellSpitzer commented on a change in pull request #4395:
URL: https://github.com/apache/iceberg/pull/4395#discussion_r835696260
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java
##########
@@ -193,15 +200,41 @@ public boolean supportColumnarReads(InputPartition
partition) {
}
}
+ static long numFilesToScan(CombinedScanTask scanTask) {
+ long fileCount = 0L;
+ for (FileScanTask file : scanTask.files()) {
+ fileCount += 1L;
Review comment:
I think it's fair to count all the delete files, but definitely in
another metric.
There will be duplicates in two cases
1. It's an equality delete
2. There is a position delete file for a data file which is split into being
read in two different tasks (this is also a problem for duplicate files being
read)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
