kbendick commented on a change in pull request #4396:
URL: https://github.com/apache/iceberg/pull/4396#discussion_r835664611
##########
File path:
spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCallStatementParser.java
##########
@@ -137,6 +139,28 @@ public void testCallParseError() {
() -> parser.parsePlan("CALL cat.system radish kebab"));
}
+ @Test
+ public void testCallStripsLeadingComments() throws ParseException {
+ // These comments are meant to look like those that systems like DBT would
add to statements.
+ List<String> callStatementsWithComments = Lists.newArrayList(
Review comment:
I added tests for comments interspersed with valid commands.
I also added an end to end test, although it's only testing one command at
present. The normal `spark.sql` parser that we fall back to doesn't seem to
handle comments very well if there are two or more statements in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
