kbendick commented on a change in pull request #4396:
URL: https://github.com/apache/iceberg/pull/4396#discussion_r835665091
##########
File path:
spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCallStatementParser.java
##########
@@ -137,6 +139,28 @@ public void testCallParseError() {
() -> parser.parsePlan("CALL cat.system radish kebab"));
}
+ @Test
+ public void testCallStripsLeadingComments() throws ParseException {
+ // These comments are meant to look like those that systems like DBT would
add to statements.
+ List<String> callStatementsWithComments = Lists.newArrayList(
Review comment:
So I think this will solve the user's problem, as only one statement is
executed at a time in dbt if I'm not mistaken (and this fix is needed
regardless to recognize Iceberg commands with comments in them.
But for multiple statements being processed, we'd have to add some splitting
around `;` like the Spark Hive CLI does
https://github.com/apache/spark/commit/450418bdfdc46c2569ff22c307de15c4fca76ebc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
