rdblue commented on a change in pull request #4307:
URL: https://github.com/apache/iceberg/pull/4307#discussion_r840701297
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java
##########
@@ -551,6 +554,139 @@ public void testManyLeafPartitions() throws
InterruptedException {
Assert.assertEquals("Rows must match", records, actualRecords);
}
+ @Test
+ public void testHiddenPartitionPaths() throws InterruptedException {
+ Schema schema = new Schema(
+ optional(1, "c1", Types.IntegerType.get()),
+ optional(2, "_c2", Types.StringType.get()),
+ optional(3, "c3", Types.StringType.get())
+ );
+ PartitionSpec spec = PartitionSpec.builderFor(schema)
+ .truncate("_c2", 2)
+ .identity("c3")
+ .build();
+ Table table = TABLES.create(schema, spec, Maps.newHashMap(),
tableLocation);
+
+ StructType structType = new StructType()
+ .add("c1", DataTypes.IntegerType)
+ .add("_c2", DataTypes.StringType)
+ .add("c3", DataTypes.StringType);
+ List<Row> records = Lists.newArrayList(
+ RowFactory.create(1, "AAAAAAAAAA", "AAAA")
+ );
+ Dataset<Row> df = spark.createDataFrame(records, structType).coalesce(1);
+
+ df.select("c1", "_c2", "c3")
+ .write()
+ .format("iceberg")
+ .mode("append")
+ .save(tableLocation);
+
+ df.write().mode("append").parquet(tableLocation +
"/data/_c2_trunc=AA/c3=AAAA");
+ df.write().mode("append").parquet(tableLocation +
"/data/_c2_trunc=AA/c3=AAAA");
+
+ Thread.sleep(1000);
Review comment:
Is this needed? We try to avoid sleeping in tests. Does the test fail
without this?
If you need to wait for some period of time, then I suggest using
`waitUntilAfter(long timestampMs)`:
```java
protected long waitUntilAfter(long timestampMillis) {
long current = System.currentTimeMillis();
while (current <= timestampMillis) {
current = System.currentTimeMillis();
}
return current;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
