stevenzwu commented on code in PR #4329: URL: https://github.com/apache/iceberg/pull/4329#discussion_r844238823
########## flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java: ########## @@ -75,7 +85,9 @@ private final boolean caseSensitive; private final boolean exposeLocality; private final Long snapshotId; + private final StreamingStartingStrategy startingStrategy; private final Long startSnapshotId; + private final Long startSnapshotTimestamp; Review Comment: @YesOrNo828 I thought about the `endSnapshotTimestamp`. This is only useful if we want to set an end time in the future. If it is an end time in the past, we don't really need the streaming read with a stop/end timestamp. We can just use a regular filter with batch read mode. We can add the `endSnapshotTimestamp` feature when there is real need for it. I just didn't include it in the current PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
