stevenzwu commented on code in PR #4329:
URL: https://github.com/apache/iceberg/pull/4329#discussion_r844362700
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##########
@@ -114,77 +128,104 @@ private ScanContext(boolean caseSensitive, Long
snapshotId, Long startSnapshotId
this.includeColumnStats = includeColumnStats;
this.exposeLocality = exposeLocality;
this.planParallelism = planParallelism;
+
+ validate();
+ }
+
+ private void validate() {
+ if (isStreaming) {
Review Comment:
we can add the validation that `startingStrategy` is null for batch mode.
will also need to change the default value to null for the config option.
```
private static final ConfigOption<StreamingStartingStrategy>
STARTING_STRATEGY =
ConfigOptions.key("starting-strategy").enumType(StreamingStartingStrategy.class)
.defaultValue(StreamingStartingStrategy.LATEST_SNAPSHOT);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
