aokolnychyi commented on code in PR #4566:
URL: https://github.com/apache/iceberg/pull/4566#discussion_r850877640
##########
core/src/main/java/org/apache/iceberg/AllDataFilesTable.java:
##########
@@ -53,47 +48,25 @@ MetadataTableType metadataTableType() {
return MetadataTableType.ALL_DATA_FILES;
}
- public static class AllDataFilesTableScan extends BaseFilesTableScan {
+ public static class AllDataFilesTableScan extends BaseAllFilesTableScan {
Review Comment:
I added `BaseAllFilesTableScan` for all aggregated file tables as I think it
is slightly cleaner. That way, we can properly override the planning method in
the parent class and consume in all children.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
