aokolnychyi commented on code in PR #4566:
URL: https://github.com/apache/iceberg/pull/4566#discussion_r850880730
##########
core/src/main/java/org/apache/iceberg/BaseAllMetadataTableScan.java:
##########
@@ -19,40 +19,56 @@
package org.apache.iceberg;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import org.apache.iceberg.events.Listeners;
+import org.apache.iceberg.events.ScanEvent;
import org.apache.iceberg.io.CloseableIterable;
+import org.apache.iceberg.relocated.com.google.common.base.Function;
+import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
+import org.apache.iceberg.relocated.com.google.common.collect.Sets;
+import org.apache.iceberg.util.ParallelIterable;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
abstract class BaseAllMetadataTableScan extends BaseMetadataTableScan {
+ private static final Logger LOG =
LoggerFactory.getLogger(BaseAllMetadataTableScan.class);
- BaseAllMetadataTableScan(TableOperations ops, Table table, Schema
fileSchema) {
- super(ops, table, fileSchema);
+ BaseAllMetadataTableScan(TableOperations ops, Table table, Schema schema,
MetadataTableType tableType) {
+ super(ops, table, schema, tableType);
}
- BaseAllMetadataTableScan(TableOperations ops, Table table, Schema schema,
TableScanContext context) {
- super(ops, table, schema, context);
+ BaseAllMetadataTableScan(TableOperations ops, Table table, Schema schema,
MetadataTableType tableType,
+ TableScanContext context) {
+ super(ops, table, schema, tableType, context);
}
- /**
- * Type of scan being performed, such as {@link
MetadataTableType#ALL_DATA_FILES} when scanning
- * a table's {@link org.apache.iceberg.AllDataFilesTable}.
- * <p>
- * Used for logging and error messages.
- */
- protected abstract String tableType();
Review Comment:
Moved it to the base metadata table scan as all metadata tables will need
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
