aokolnychyi commented on code in PR #4566:
URL: https://github.com/apache/iceberg/pull/4566#discussion_r851376908
##########
core/src/main/java/org/apache/iceberg/AllDataFilesTable.java:
##########
@@ -53,47 +48,25 @@ MetadataTableType metadataTableType() {
return MetadataTableType.ALL_DATA_FILES;
}
- public static class AllDataFilesTableScan extends BaseFilesTableScan {
+ public static class AllDataFilesTableScan extends BaseAllFilesTableScan {
- AllDataFilesTableScan(TableOperations ops, Table table, Schema fileSchema)
{
- super(ops, table, fileSchema, MetadataTableType.ALL_DATA_FILES);
+ AllDataFilesTableScan(TableOperations ops, Table table, Schema schema) {
+ super(ops, table, schema, MetadataTableType.ALL_DATA_FILES);
}
- private AllDataFilesTableScan(TableOperations ops, Table table, Schema
schema, Schema fileSchema,
Review Comment:
I no longer pass both `schema` and `fileSchema` as those are same and can be
accessed by `schema()` from the common parent class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
