rdblue commented on code in PR #4525:
URL: https://github.com/apache/iceberg/pull/4525#discussion_r863326344
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -473,7 +494,11 @@ public NestedField asRequired() {
if (!isOptional) {
return this;
}
- return new NestedField(false, id, name, type, doc);
+ return new NestedField(false, id, name, type, doc, initialDefault,
writeDefault);
+ }
+
+ public NestedField updateWriteDefault(Object newWriteDefault) {
Review Comment:
I don't think there are other methods like this. Is it worth adding a new
pattern for just this? Why not add `updateDoc`? I think I'd rather copy where
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
