rdblue commented on code in PR #4525:
URL: https://github.com/apache/iceberg/pull/4525#discussion_r863325993
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -415,43 +415,64 @@ public int hashCode() {
public static class NestedField implements Serializable {
public static NestedField optional(int id, String name, Type type) {
- return new NestedField(true, id, name, type, null);
+ return new NestedField(true, id, name, type, null, null, null);
}
public static NestedField optional(int id, String name, Type type, String
doc) {
- return new NestedField(true, id, name, type, doc);
+ return new NestedField(true, id, name, type, doc, null, null);
+ }
+
+ public static NestedField optional(int id, String name, Type type, String
doc,
+ Object initialDefault, Object
writeDefault) {
+ return new NestedField(true, id, name, type, doc, initialDefault,
writeDefault);
}
public static NestedField required(int id, String name, Type type) {
- return new NestedField(false, id, name, type, null);
+ return new NestedField(false, id, name, type, null, null, null);
}
public static NestedField required(int id, String name, Type type, String
doc) {
- return new NestedField(false, id, name, type, doc);
+ return new NestedField(false, id, name, type, doc, null, null);
+ }
+
+ public static NestedField required(int id, String name, Type type, String
doc,
+ Object initialDefault, Object
writeDefault) {
+ return new NestedField(false, id, name, type, doc, initialDefault,
writeDefault);
}
public static NestedField of(int id, boolean isOptional, String name, Type
type) {
- return new NestedField(isOptional, id, name, type, null);
+ return new NestedField(isOptional, id, name, type, null, null, null);
}
public static NestedField of(int id, boolean isOptional, String name, Type
type, String doc) {
- return new NestedField(isOptional, id, name, type, doc);
+ return new NestedField(isOptional, id, name, type, doc, null, null);
+ }
+
+ public static NestedField of(int id, boolean isOptional, String name, Type
type, String doc,
+ Object initialDefault, Object writeDefault) {
+ return new NestedField(isOptional, id, name, type, doc, initialDefault,
writeDefault);
}
private final boolean isOptional;
private final int id;
private final String name;
private final Type type;
private final String doc;
+ private final Object initialDefault;
+ private final Object writeDefault;
+
- private NestedField(boolean isOptional, int id, String name, Type type,
String doc) {
+ private NestedField(boolean isOptional, int id, String name, Type type,
String doc,
+ Object initialDefault, Object writeDefault) {
Review Comment:
Style: In Iceberg always start all argument lines at the same point, either
all indented after the method declaration (aligned with `boolean isOptional,
...`) or all starting at the same continuation indent level. This mixes the two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
