rdblue commented on code in PR #4926:
URL: https://github.com/apache/iceberg/pull/4926#discussion_r889295640
##########
api/src/main/java/org/apache/iceberg/SnapshotUpdate.java:
##########
@@ -60,4 +60,9 @@
* @return this for method chaining
*/
ThisT scanManifestsWith(ExecutorService executorService);
+
+ /**
+ * Perform operations a particular branch
+ */
+ ThisT branch(String branch);
Review Comment:
I think we need to add another word to make it clear what is happening here,
like `toBranch` or `forBranch`. Just branch isn't obvious when you're reading
it:
```java
table.newOverwrite()
.overwriteByRowFilter(filter)
.addFile(one)
.addFile(two)
.toBranch(b)
.commit()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
