rdblue commented on code in PR #4926:
URL: https://github.com/apache/iceberg/pull/4926#discussion_r889298509
##########
core/src/test/java/org/apache/iceberg/TestFastAppend.java:
##########
@@ -478,4 +478,26 @@ public void testIncludedPartitionSummaryLimit() {
String changedPartitions =
table.currentSnapshot().summary().get(SnapshotSummary.CHANGED_PARTITION_COUNT_PROP);
Assert.assertEquals("Should set changed partition count", "2",
changedPartitions);
}
+
+ @Test
+ public void testAppendToBranch() {
Review Comment:
I think we need more tests for fast append:
* Where no snapshots or branches exist
* Where the named branch does not exist, but main does
* Possibly others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
