kbendick commented on code in PR #4989:
URL: https://github.com/apache/iceberg/pull/4989#discussion_r891633026
##########
.github/workflows/api-binary-compatibility.yml:
##########
@@ -38,15 +38,25 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
+ if: github.event_name == 'pull_request'
+ with:
+ # fetch-depth of zero ensures that the tags are pulled in and we're
not in a detached HEAD state
+ # revapi depends on the tags, specifically the tag from git
describe, to find the relevant override
+ # in the .palantir/revapi.yml file
+ #
+ # See https://github.com/actions/checkout/issues/124
+ fetch-depth: 0
+ ref: ${{ github.event.pull_request.head.ref }}
+ - uses: actions/checkout@v2
+ if: github.event_name == 'push'
+ with:
+ fetch-depth: 0
- uses: actions/setup-java@v1
with:
java-version: 11
- - uses: actions/cache@v2
- with:
- path: ~/.gradle/caches
- key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
- restore-keys: ${{ runner.os }}-gradle
- - run: ./gradlew :iceberg-api:revapi
Review Comment:
We can _potentially_ add back in the cache step, but for now I'd like to get
this working in `master` before fiddling with the individual arguments any
further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
