kbendick commented on code in PR #4989:
URL: https://github.com/apache/iceberg/pull/4989#discussion_r891834499
##########
.github/workflows/api-binary-compatibility.yml:
##########
@@ -38,15 +38,25 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
+ if: github.event_name == 'pull_request'
+ with:
+ # fetch-depth of zero ensures that the tags are pulled in and we're
not in a detached HEAD state
+ # revapi depends on the tags, specifically the tag from git
describe, to find the relevant override
+ # in the .palantir/revapi.yml file
+ #
+ # See https://github.com/actions/checkout/issues/124
+ fetch-depth: 0
+ ref: ${{ github.event.pull_request.head.ref }}
Review Comment:
Yes, I believe it should. Somewhat hard to test admittedly. But the merge
commit counts as a `push` against the target branch. For us, that’s typically
master so keeping the default is fine.
I got this from the docs of the action and the associated issue. That’s why
there’s a checkout if push step just below.
We can double check once it is merged in though. For our current uses
(merging into master), it’ll be fine. I’ll double check whether the GitHub
context has anything on push that we might grab as well though for the ref
field.
Good question @findepi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
