rdblue commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r894944629
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##########
@@ -143,7 +147,26 @@ public void run(SourceContext<FlinkInputSplit> ctx) throws
Exception {
}
}
- private void monitorAndForwardSplits() {
+ private long maxReachableSnapshotId(long lastConsumedSnapshotId, long
latestSnapshotId,
+ int maxSnapshotCountPerMonitorInterval) {
+ // This doesn't consider snapshot inheritance since it is already checked
in state initialization.
Review Comment:
What do you mean by "snapshot inheritance" here?
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##########
@@ -143,7 +147,26 @@ public void run(SourceContext<FlinkInputSplit> ctx) throws
Exception {
}
}
- private void monitorAndForwardSplits() {
+ private long maxReachableSnapshotId(long lastConsumedSnapshotId, long
latestSnapshotId,
+ int maxSnapshotCountPerMonitorInterval) {
Review Comment:
I think this should be `maxSnapshots`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
