stevenzwu commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r895922912
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##########
@@ -82,6 +82,9 @@ public class ScanContext implements Serializable {
private static final ConfigOption<Boolean> INCLUDE_COLUMN_STATS =
ConfigOptions.key("include-column-stats").booleanType().defaultValue(false);
+ private static final ConfigOption<Integer>
MAX_SNAPSHOT_COUNT_PER_MONITOR_INTERVAL =
+
ConfigOptions.key("max-snapshot-count-per-monitor-interval").intType().defaultValue(Integer.MAX_VALUE);
Review Comment:
I found `snapshot-group-limit` less intuitive. what does the `group` mean in
this context. `monitor-interval` is an existing config that user is already
familiar.
I do agree that we should make the config name clear. Just brainstorming
more names. what about `max-snapshot-count-per-incremental-scan` or
`max-snapshot-count-per-planning`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
