rdblue commented on code in PR #3998:
URL: https://github.com/apache/iceberg/pull/3998#discussion_r900335161
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java:
##########
@@ -413,7 +426,8 @@ private SingleOutputStreamOperator<WriteResult>
appendWriter(DataStream<RowData>
}
}
- IcebergStreamWriter<RowData> streamWriter = createStreamWriter(table,
flinkRowType, equalityFieldIds, upsertMode);
+ IcebergStreamWriter<RowData> streamWriter = createStreamWriter(table,
flinkWriteConf.targetDataFileSize(),
+ flinkWriteConf.dataFileFormat(), flinkWriteConf.props(),
flinkRowType, equalityFieldIds, upsertMode);
Review Comment:
`props` should not be used because it can't capture the correct logic for
selecting configuration with precedence (options before table config). Instead,
pass the write config. That would allow you to also remove the file format and
upsert mode arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
