rdblue commented on code in PR #3998:
URL: https://github.com/apache/iceberg/pull/3998#discussion_r900341463
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/RowDataTaskWriterFactory.java:
##########
@@ -59,6 +60,16 @@ public RowDataTaskWriterFactory(Table table,
FileFormat format,
List<Integer> equalityFieldIds,
boolean upsert) {
+ this(table, table.properties(), flinkSchema, targetFileSizeBytes, format,
equalityFieldIds, upsert);
Review Comment:
The writer should be passed the table properties, without merging in the
options. I just looked at the file appender and that appears to be the correct
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
