aokolnychyi commented on code in PR #5077:
URL: https://github.com/apache/iceberg/pull/5077#discussion_r904030461
##########
api/src/main/java/org/apache/iceberg/CombinedScanTask.java:
##########
@@ -24,13 +24,18 @@
/**
* A scan task made of several ranges from files.
*/
-public interface CombinedScanTask extends ScanTask {
+public interface CombinedScanTask extends ScanTaskGroup<FileScanTask> {
/**
* Return the {@link FileScanTask tasks} in this combined task.
* @return a Collection of FileScanTask instances.
*/
Collection<FileScanTask> files();
Review Comment:
I am fine either way. This naming probably makes sense given that we return
`FileScanTask`s. I just wanted to have a more flexible naming in
`ScanTaskGroup` so I added a new method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
