RussellSpitzer commented on code in PR #4325:
URL: https://github.com/apache/iceberg/pull/4325#discussion_r922408588
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -289,16 +289,17 @@ public static List<DataFile> listPartition(SparkPartition
partition, PartitionSp
* @param conf a serializable Hadoop conf
* @param metricsConfig a metrics conf
* @param mapping a name mapping
+ * @param skipOnError if true, skip files which cannot be imported into
Iceberg
* @return a List of DataFile
* @deprecated use {@link TableMigrationUtil#listPartition(Map, String,
String, PartitionSpec, Configuration,
- * MetricsConfig, NameMapping)}
+ * MetricsConfig, NameMapping, boolean)}
*/
@Deprecated
public static List<DataFile> listPartition(SparkPartition partition,
PartitionSpec spec,
SerializableConfiguration conf,
MetricsConfig metricsConfig,
- NameMapping mapping) {
+ NameMapping mapping, boolean
skipOnError) {
Review Comment:
Cannot change the signature of a deprecated method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
