RussellSpitzer commented on code in PR #4325:
URL: https://github.com/apache/iceberg/pull/4325#discussion_r922422942
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -496,7 +580,8 @@ private static void
importUnpartitionedSparkTable(SparkSession spark, TableIdent
* @param checkDuplicateFiles if true, throw exception if import results in
a duplicate data file
*/
public static void importSparkPartitions(SparkSession spark,
List<SparkPartition> partitions, Table targetTable,
- PartitionSpec spec, String
stagingDir, boolean checkDuplicateFiles) {
+ PartitionSpec spec, String
stagingDir, boolean checkDuplicateFiles,
Review Comment:
Change to a public api needs a fallback,
``` public static void importSparkPartitions(SparkSession spark,
List<SparkPartition> partitions, Table targetTable, PartitionSpec spec, String
stagingDir, boolean checkDuplicateFiles ) ```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
