stevenzwu commented on code in PR #5348:
URL: https://github.com/apache/iceberg/pull/5348#discussion_r938433859
##########
api/src/main/java/org/apache/iceberg/metrics/DefaultMetricsContext.java:
##########
@@ -22,6 +22,7 @@
/** A default {@link MetricsContext} implementation that uses native Java
counters/timers. */
public class DefaultMetricsContext implements MetricsContext {
+ private static final int DEFAULT_HISTOGRAM_RESERVOIR_SIZE = 1024;
Review Comment:
I am fine with 10K as default value. 10k size long[] array would cost 80 KB
per metric. 100 histogram metrics would be 8 MB, which isn't too bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
