singhpk234 commented on code in PR #5437:
URL: https://github.com/apache/iceberg/pull/5437#discussion_r939710203
##########
aws/src/test/java/org/apache/iceberg/aws/glue/TestGlueCatalog.java:
##########
@@ -585,4 +589,21 @@ public void testValidateIdentifierSkipNameValidation() {
CATALOG_NAME, WAREHOUSE_PATH, props, glue,
LockManagers.defaultLockManager(), null);
Assert.assertEquals(glueCatalog.isValidIdentifier(TableIdentifier.parse("db-1.a-1")),
true);
}
+
+ @Test
+ public void testS3FileIOSerialization() throws IOException {
Review Comment:
Initially added this as a glue test considering only flow of S3FileIO
initialization was problematic and newTableOps were protected ...
adding handling of the immutable map in S3FileIO itself, definitely makes
sense.
removed this test and added one for S3FileIO, thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
