rdblue commented on code in PR #5437:
URL: https://github.com/apache/iceberg/pull/5437#discussion_r942852497
##########
spark/v3.3/build.gradle:
##########
@@ -87,6 +87,14 @@
project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}") {
testImplementation project(path: ':iceberg-api', configuration:
'testArtifacts')
testImplementation project(path: ':iceberg-core', configuration:
'testArtifacts')
testImplementation project(path: ':iceberg-data', configuration:
'testArtifacts')
+ testImplementation project(':iceberg-aws')
+ testImplementation 'software.amazon.awssdk:s3'
+ testImplementation 'software.amazon.awssdk:dynamodb'
+ testImplementation 'software.amazon.awssdk:kms'
+ testImplementation 'software.amazon.awssdk:glue'
+ testImplementation project(':iceberg-gcp')
+ testImplementation platform('com.google.cloud:libraries-bom')
+ testImplementation 'com.google.cloud:google-cloud-storage'
Review Comment:
Aren't these already pulled in through core?
##########
build.gradle:
##########
@@ -379,6 +379,7 @@ project(':iceberg-aws') {
testImplementation 'software.amazon.awssdk:iam'
testImplementation 'software.amazon.awssdk:s3control'
+ testImplementation 'com.twitter:chill-java'
Review Comment:
Why is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
