rdblue commented on code in PR #5427:
URL: https://github.com/apache/iceberg/pull/5427#discussion_r939730460
##########
core/src/main/java/org/apache/iceberg/util/JsonUtil.java:
##########
@@ -184,6 +184,11 @@ public static String getStringOrNull(String property,
JsonNode node) {
return pNode.asText();
}
+ public static JsonNode get(String property, JsonNode node) {
+ Preconditions.checkArgument(node.has(property), "Cannot parse missing
object %s", property);
Review Comment:
How do you know that the missing property needed to be an object? I think
this should be `Cannot parse, missing field: %s`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
