rdblue commented on code in PR #5427: URL: https://github.com/apache/iceberg/pull/5427#discussion_r939731289
########## core/src/main/java/org/apache/iceberg/metrics/CounterResultParser.java: ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.metrics; + +import com.fasterxml.jackson.core.JsonGenerator; +import com.fasterxml.jackson.databind.JsonNode; +import java.io.IOException; +import org.apache.iceberg.metrics.MetricsContext.Unit; +import org.apache.iceberg.metrics.ScanReport.CounterResult; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.util.JsonUtil; + +class CounterResultParser { + private static final String MISSING_FIELD_ERROR_MSG = + "Cannot parse counter from '%s': Missing field '%s'"; + + static final CounterResult<Integer> NOOP_INT_COUNTER = + new CounterResult<>("undefined", Unit.UNDEFINED, 0); + static final CounterResult<Long> NOOP_LONG_COUNTER = + new CounterResult<>("undefined", Unit.UNDEFINED, 0L); + + private static final String NAME = "name"; + private static final String UNIT = "unit"; + private static final String VALUE = "value"; + private static final String TYPE = "type"; + + private CounterResultParser() {} + + static String toJson(CounterResult<?> counterResult) { + return toJson(counterResult, false); + } + + static String toJson(CounterResult<?> counterResult, boolean pretty) { + return JsonUtil.generate(gen -> toJson(counterResult, gen), pretty); + } + + static void toJson(CounterResult<?> counter, JsonGenerator gen) throws IOException { + Preconditions.checkArgument(null != counter, "Invalid counter: null"); + + gen.writeStartObject(); + gen.writeStringField(NAME, counter.name()); + gen.writeStringField(UNIT, counter.unit().name()); Review Comment: Can we convert the name to lower case? We avoid using upper case for enums in Iceberg specs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
