kbendick commented on PR #5434: URL: https://github.com/apache/iceberg/pull/5434#issuecomment-1207497436
> I think it's better to put names like this after a `:` instead of adding characters that can get copied and moved to other places. Putting names after `:` still allows you to see when they are empty or null (e.g. `Cannot find field: `) without adding non-whitespace characters. I know I approved this PR, but I do tend to agree with this argument. In particular, I find value in having any variable / changing value in a log (in this case the field name) after `:` so that there is a common leading string to search for in the logs. Combined with the first line of the stack trace, it should be clear in context, for example, that an integer was attempting to be parsed as we're in the function `getInt` etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
