nastra commented on PR #5434: URL: https://github.com/apache/iceberg/pull/5434#issuecomment-1207735685
> I think it's better to put names like this after a `:` instead of adding characters that can get copied and moved to other places. Putting names after `:` still allows you to see when they are empty or null (e.g. `Cannot find field: `) without adding non-whitespace characters. That makes sense, but how would we want to handle something like `Cannot parse %s from non-array value: %s`? I feel that `Cannot parse '%s' from non-array value: %s` improves readability. Or we could add the property name to the end in this particular case to have `Cannot parse from non-array value: %s: %s`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
