huaxingao opened a new pull request, #5638: URL: https://github.com/apache/iceberg/pull/5638
In `overwrite(Filter[] filters)`, I think we need to bind to find out if the columns in the Filters are valid columns and throw Exception if not. I think we probably don't need the similar check in [`deleteWhere(Filter[] filters)`](https://github.com/apache/iceberg/blob/master/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java#L310) because before calling this method, [`canDeleteWhere(Filter[] filters)`](https://github.com/apache/iceberg/blob/master/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java#L254) is already called. In `canDeleteWhere(Filter[] filters)`, bind will be called in [`canDeleteUsingMetadata`](https://github.com/apache/iceberg/blob/master/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java#L269). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
