rdblue commented on code in PR #5638:
URL: https://github.com/apache/iceberg/pull/5638#discussion_r956790144
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java:
##########
@@ -47,14 +55,39 @@ public void removeTable() {
@Test
public void testTableEquality() throws NoSuchTableException {
- CatalogManager catalogManager = spark.sessionState().catalogManager();
- TableCatalog catalog = (TableCatalog) catalogManager.catalog(catalogName);
- Identifier identifier = Identifier.of(tableIdent.namespace().levels(),
tableIdent.name());
- SparkTable table1 = (SparkTable) catalog.loadTable(identifier);
- SparkTable table2 = (SparkTable) catalog.loadTable(identifier);
-
+ SparkTable table1 = loadTable();
+ SparkTable table2 = loadTable();
// different instances pointing to the same table must be equivalent
Assert.assertNotSame("References must be different", table1, table2);
Assert.assertEquals("Tables must be equivalent", table1, table2);
}
+
+ @Test
+ public void testOverwriteFilterConversions() throws NoSuchTableException {
Review Comment:
When does this happen in practice? Can we have a test that mirrors a
real-world situation a bit more closely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
