danielcweeks commented on code in PR #5797:
URL: https://github.com/apache/iceberg/pull/5797#discussion_r974777890


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -228,13 +228,7 @@ protected TableOperations newTableOps(TableIdentifier 
tableIdentifier) {
     }
 
     return new GlueTableOperations(
-        glue,
-        lockManager,
-        catalogName,
-        awsProperties,
-        catalogProperties,

Review Comment:
   Hey @JonasJ-ap, I think this means that the GlueCatalog isn't being 
correctly initialized in the integration tests.  The `initialize()` call should 
set the value correctly.  I'm guessing some of the testing init methods aren't 
consistent with the implementation in from the catalog interface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to