amogh-jahagirdar commented on code in PR #5797:
URL: https://github.com/apache/iceberg/pull/5797#discussion_r974848173
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -228,13 +228,7 @@ protected TableOperations newTableOps(TableIdentifier
tableIdentifier) {
}
return new GlueTableOperations(
- glue,
- lockManager,
- catalogName,
- awsProperties,
- catalogProperties,
Review Comment:
Yeah the expectation is that for loading the catalog dynamically, all the
fields (including catalogProperties) are set via initialize() as @danielcweeks
suggested, so I think let's just fix the integration test catalog
initialization.
As for simplifying the code, sure I think we can have a common return point
through properties(); I would say let's correct the integration tests in
https://github.com/apache/iceberg/pull/5784 and then we can come back here, and
re-run the tests after the common return point change. If they succeed, then we
should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
