wypoon commented on PR #5742: URL: https://github.com/apache/iceberg/pull/5742#issuecomment-1256819853
> @wypoon, we can put the new test case in the class like `TestPositionFilter`, in that case, it is easier to modify the threshold, and we don't have to touch any thing related to Spark. @flyrain I don't think `TestPositionFilter` is the right place for testing the code path that is not exercised by existing tests. What I want to test is that the custom metric I added in #4588 produces the correct count of deletes applied, when using the streaming delete filter. E.g., I want to check `TestSparkReaderDeletes#testMixedPosAndEqDeletesWithDeletedColumn` passes when the streaming delete filter is used. I think the best way is still to run `TestSparkReaderDeletes` but with the threshold to use the streaming delete filter set to a low number from the test. I'll explore the system property approach, unless you have another suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
