wypoon commented on code in PR #5742:
URL: https://github.com/apache/iceberg/pull/5742#discussion_r979326211
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -58,11 +58,11 @@
public abstract class DeleteFilter<T> {
private static final Logger LOG =
LoggerFactory.getLogger(DeleteFilter.class);
- private static final long DEFAULT_SET_FILTER_THRESHOLD = 100_000L;
+ private static final long DEFAULT_STREAM_FILTER_THRESHOLD = 100_000L;
private static final Schema POS_DELETE_SCHEMA =
new Schema(MetadataColumns.DELETE_FILE_PATH,
MetadataColumns.DELETE_FILE_POS);
- private final long setFilterThreshold;
+ private final long streamFilterThreshold;
Review Comment:
I think calling this the streamFilterThreshold is more appropriate, since it
is the threshold past which we use the streaming delete filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
