findepi commented on code in PR #5795:
URL: https://github.com/apache/iceberg/pull/5795#discussion_r983265802
##########
core/src/main/java/org/apache/iceberg/ReachableFileUtil.java:
##########
@@ -113,4 +113,21 @@ public static List<String> manifestListLocations(Table
table) {
}
return manifestListLocations;
}
+
+ /**
+ * Returns locations of statistics files in a table.
+ *
+ * @param table table for which statistics files needs to be listed
+ * @return the location of statistics files
+ */
+ public static List<String> statisticsFilesLocations(Table table) {
+ List<String> statisticsFilesLocations = Lists.newArrayList();
+ TableOperations ops = ((HasTableOperations) table).operations();
Review Comment:
@rdblue here I am following existing code in the `ReachableFileUtil` class
https://github.com/apache/iceberg/blob/c07f2aabc0a1d02f068ecf1514d2479c0fbdd3b0/core/src/main/java/org/apache/iceberg/ReachableFileUtil.java#L62-L64
since this class already casts to `HasTableOperations`, I assumed it's OK to
do that and therefore removed public API changes from this PR.
If you want first merge Table API changes, the
https://github.com/apache/iceberg/pull/4741 is ready for your review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
