findepi commented on code in PR #5795:
URL: https://github.com/apache/iceberg/pull/5795#discussion_r983278571
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -876,6 +890,82 @@ protected long waitUntilAfter(long timestampMillis) {
return current;
}
+ @Test
+ public void testRemoveOrphanFilesWithStatisticFiles() throws Exception {
+ Table table =
+ TABLES.create(
+ SCHEMA,
+ PartitionSpec.unpartitioned(),
+ ImmutableMap.of(TableProperties.FORMAT_VERSION, "2"),
+ tableLocation);
+
+ List<ThreeColumnRecord> records =
+ Lists.newArrayList(new ThreeColumnRecord(1, "AAAAAAAAAA", "AAAA"));
+ Dataset<Row> df = spark.createDataFrame(records,
ThreeColumnRecord.class).coalesce(1);
+ df.select("c1", "c2",
"c3").write().format("iceberg").mode("append").save(tableLocation);
+
+ table.refresh();
+ long snapshotId = table.currentSnapshot().snapshotId();
+ long snapshotSequenceNumber = table.currentSnapshot().sequenceNumber();
+
+ File statsLocation =
+ new File(new URI(tableLocation))
+ .toPath()
+ .resolve("data")
+ .resolve("some-stats-file")
+ .toFile();
+ StatisticsFile statisticsFile;
+ try (PuffinWriter puffinWriter =
Puffin.write(Files.localOutput(statsLocation)).build()) {
+ puffinWriter.add(
+ new Blob(
+ "some-blob-type",
+ ImmutableList.of(1),
+ snapshotId,
+ snapshotSequenceNumber,
+ ByteBuffer.wrap("blob
content".getBytes(StandardCharsets.UTF_8))));
+ puffinWriter.finish();
+ statisticsFile =
+ new GenericStatisticsFile(
+ snapshotId,
+ statsLocation.toString(),
+ puffinWriter.fileSize(),
+ puffinWriter.footerSize(),
+ puffinWriter.writtenBlobsMetadata().stream()
+ .map(GenericBlobMetadata::from)
+ .collect(ImmutableList.toImmutableList()));
+ }
+
+ Transaction transaction = table.newTransaction();
+ transaction.updateStatistics().setStatistics(snapshotId,
statisticsFile).commit();
+ transaction.commitTransaction();
+
+ SparkActions.get()
+ .deleteOrphanFiles(table)
+ .olderThan(System.currentTimeMillis() + TimeUnit.DAYS.toMillis(365))
+ .execute();
+
+ Assertions.assertThat(statsLocation.exists()).as("stats file should
exist").isTrue();
+ Assertions.assertThat(statsLocation.length())
+ .as("stats file length")
+ .isEqualTo(statisticsFile.fileSizeInBytes());
+
+ transaction = table.newTransaction();
+
transaction.updateStatistics().removeStatistics(statisticsFile.snapshotId()).commit();
+ transaction.commitTransaction();
+
+ DeleteOrphanFiles.Result result =
+ SparkActions.get()
+ .deleteOrphanFiles(table)
+ .olderThan(System.currentTimeMillis() +
TimeUnit.DAYS.toMillis(365))
Review Comment:
I saw tests using
```java
Thread.sleep(1000);
...
.deleteOrphanFiles(table)
.olderThan(System.currentTimeMillis())
```
i wanted to avoid sleep in the test, so that it run faster on CI, that's why
i didn't follow existing pattern that i found.
i will change to `+ 1000`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
