rdblue commented on code in PR #5926:
URL: https://github.com/apache/iceberg/pull/5926#discussion_r989539742
##########
api/src/main/java/org/apache/iceberg/expressions/ManifestEvaluator.java:
##########
@@ -148,10 +148,6 @@ public <T> Boolean isNaN(BoundReference<T> ref) {
return ROWS_CANNOT_MATCH;
}
- if (allValuesAreNull(stats.get(pos), ref.type().typeId())) {
Review Comment:
I don't think this is correct. The `containsNaN` field was introduced later,
so it can be null for metadata files that were written before we tracked NaN
values in partitions. In that case, if we know that all values are null then
none of them are NaN and can then eliminate scanning the manifest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
