Fokko commented on code in PR #5926:
URL: https://github.com/apache/iceberg/pull/5926#discussion_r989731857
##########
api/src/main/java/org/apache/iceberg/expressions/ManifestEvaluator.java:
##########
@@ -148,10 +148,6 @@ public <T> Boolean isNaN(BoundReference<T> ref) {
return ROWS_CANNOT_MATCH;
}
- if (allValuesAreNull(stats.get(pos), ref.type().typeId())) {
Review Comment:
Yes, you are right on that one! It didn't think of encoding NaN as None.
Then this makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
