rdblue commented on code in PR #5893:
URL: https://github.com/apache/iceberg/pull/5893#discussion_r989550192
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -155,11 +171,30 @@ public static ManifestWriter<DataFile>
write(PartitionSpec spec, OutputFile outp
*/
public static ManifestWriter<DataFile> write(
Review Comment:
No, there's no need. It is better to have a version that defaults than to
leave callers guessing how to fill in details that don't matter much. The worst
case is that someone guesses and ends up using a codec like snappy when they
should just leave it to default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
