rdblue commented on code in PR #5893:
URL: https://github.com/apache/iceberg/pull/5893#discussion_r989552055
##########
core/src/test/java/org/apache/iceberg/TestTransaction.java:
##########
@@ -535,7 +535,12 @@ public void testTransactionRetryAndAppendManifests()
throws Exception {
// create a manifest append
OutputFile manifestLocation =
Files.localOutput("/tmp/" + UUID.randomUUID().toString() + ".avro");
- ManifestWriter<DataFile> writer = ManifestFiles.write(table.spec(),
manifestLocation);
+ ManifestWriter<DataFile> writer =
+ ManifestFiles.write(
+ table.spec(),
+ manifestLocation,
+ table.properties().get(TableProperties.AVRO_COMPRESSION),
+ table.properties().get(TableProperties.AVRO_COMPRESSION_LEVEL));
Review Comment:
I don't think it is worth updating places like this. It's just needless code
churn when we have no reason to think that the codec would be set or matter to
the test. Can you remove cases like this from the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
