JonasJ-ap commented on PR #5939: URL: https://github.com/apache/iceberg/pull/5939#issuecomment-1272571569
> Thanks for the fix, I also overlooked the fact that the request is not serializable. Technically we can still store the assume role request, just need to not make it as `transient volatile` and initialize it if null. But it feels like an overkill given we probably need the request every 6 hours or so and it's okay to create it at runtime. So I agree this is the right way to fix. Let me know when this is out of draft status and I will review again! @jackye1995 Thank you for your explanation. I marked this PR "Ready to be reviewed" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
