JonasJ-ap commented on PR #5939: URL: https://github.com/apache/iceberg/pull/5939#issuecomment-1272677978
> Can we add a test to do a round trip serialization check to prevent this from happening again? You can use `SerializationUtil` Sure. Based on my understanding, all client factories should be serializable. Hence, I added three unit test to check the serializability of `DefaultAwsClientFactory`, `AssumeRoleAwsClientFactory`, and `LakeFormationAwsClientFactory`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
