jzhuge commented on PR #4925:
URL: https://github.com/apache/iceberg/pull/4925#issuecomment-1279902810
@rdblue Added `buildSqlView` for convenience, so the above example can be
shortened as:
```java
viewCatalog.buildSqlView(ident)
.withSchema(schema)
.withSql("SELECT foo FROM base")
.withDialect("spark")
.withDefaultCatalog("prodhive")
.withDefaultNamespace(Collections.singleList("default"))
.withProperty("k1", "v1")
.withLocation(s3Loc)
.createOrReplace()
```
Should we add this convenience api for common use cases?
For builder method names, should we use `with` prefix or not? I have
examples of both in the existing code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
