jzhuge commented on PR #4925:
URL: https://github.com/apache/iceberg/pull/4925#issuecomment-1283182848
@rdblue @danielcweeks @stevenzwu @amogh-jahagirdar @jackye1995 @nastra
Please take another look.
Summary of discussions:
- ViewBuilder API focuses on SQL view first. Do not expose vague APIs to
manage a list of representations.
- Interface name `ViewVersion` not ideal, but no good alternative.
- Version ID type is integer, not long.
Usage example:
```
viewCatalog.buildView(ident)
.withSchema(schema)
.withQuery("SELECT foo FROM base")
.withDialect("spark")
.withDefaultCatalog("prodhive")
.withDefaultNamespace(Collections.singleList("default"))
.withProperty("k1", "v1")
.withLocation(s3Loc)
.createOrReplace();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
