amogh-jahagirdar commented on code in PR #5618:
URL: https://github.com/apache/iceberg/pull/5618#discussion_r997572791
##########
core/src/test/java/org/apache/iceberg/TestDeleteFiles.java:
##########
@@ -68,38 +68,46 @@ public class TestDeleteFiles extends TableTestBase {
))
.build();
- @Parameterized.Parameters(name = "formatVersion = {0}")
+ private final String branch;
+
+ @Parameterized.Parameters(name = "formatVersion = {0}, branch = {1}")
public static Object[] parameters() {
- return new Object[] {1, 2};
+ return new Object[][] {
+ new Object[] {1, "main"},
+ new Object[] {1, "testBranch"},
+ new Object[] {2, "main"},
+ new Object[] {2, "testBranch"}
+ };
}
- public TestDeleteFiles(int formatVersion) {
+ public TestDeleteFiles(int formatVersion, String branch) {
super(formatVersion);
+ this.branch = branch;
}
@Test
public void testMultipleDeletes() {
-
table.newAppend().appendFile(FILE_A).appendFile(FILE_B).appendFile(FILE_C).commit();
+ Snapshot append =
+ commit(
+ table,
+
table.newAppend().appendFile(FILE_A).appendFile(FILE_B).appendFile(FILE_C),
+ branch);
Assert.assertEquals("Metadata should be at version 1", 1L, (long)
version());
- Snapshot append = readMetadata().currentSnapshot();
Review Comment:
I've updated with an additional latestSnapshot method which takes in
`TableMetadata` . The cases which were using it before, are now using this
method instead of through the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
